Error handling mini refractoring

[github/Chocobozzz/PeerTube.git] / controllers / api / v1 / videos.js

diff --git a/controllers/api/v1/videos.js b/controllers/api/v1/videos.js
index aa8cb466be026e7be9e7613c34e9d8de6b9fa1f4..eec95c8018e762d7200728d15c9eeed1f9a08d07 100644 (file)
--- a/controllers/api/v1/videos.js
+++ b/controllers/api/v1/videos.js
@@ -1,46 +1,90 @@
 ;(function () {
   'use strict'
 
-  var express = require('express')
   var config = require('config')
   var crypto = require('crypto')
+  var express = require('express')
   var multer = require('multer')
-  var router = express.Router()
 
+  var logger = require('../../../helpers/logger')
+  var friends = require('../../../lib/friends')
   var middleware = require('../../../middlewares')
-  var miscMiddleware = middleware.misc
+  var cacheMiddleware = middleware.cache
   var reqValidator = middleware.reqValidators.videos
-  var videos = require('../../../models/videos')
+  var Videos = require('../../../models/videos') // model
+  var videos = require('../../../lib/videos')
+  var webtorrent = require('../../../lib/webTorrentNode')
 
+  var router = express.Router()
   var uploads = config.get('storage.uploads')
 
-  function listVideos (req, res, next) {
-    videos.list(function (err, videos_list) {
-      if (err) return next(err)
+  // multer configuration
+  var storage = multer.diskStorage({
+    destination: function (req, file, cb) {
+      cb(null, uploads)
+    },
 
-      res.json(videos_list)
-    })
-  }
+    filename: function (req, file, cb) {
+      var extension = ''
+      if (file.mimetype === 'video/webm') extension = 'webm'
+      else if (file.mimetype === 'video/mp4') extension = 'mp4'
+      else if (file.mimetype === 'video/ogg') extension = 'ogv'
+      crypto.pseudoRandomBytes(16, function (err, raw) {
+        var fieldname = err ? undefined : raw.toString('hex')
+        cb(null, fieldname + '.' + extension)
+      })
+    }
+  })
 
-  function searchVideos (req, res, next) {
-    videos.search(req.params.name, function (err, videos_list) {
-      if (err) return next(err)
+  var reqFiles = multer({ storage: storage }).fields([{ name: 'input_video', maxCount: 1 }])
 
-      res.json(videos_list)
-    })
-  }
+  router.get('/', cacheMiddleware.cache(false), listVideos)
+  router.post('/', reqFiles, reqValidator.videosAdd, cacheMiddleware.cache(false), addVideo)
+  router.get('/:id', reqValidator.videosGet, cacheMiddleware.cache(false), getVideos)
+  router.delete('/:id', reqValidator.videosRemove, cacheMiddleware.cache(false), removeVideo)
+  router.get('/search/:name', reqValidator.videosSearch, cacheMiddleware.cache(false), searchVideos)
 
-  function addVideos (req, res, next) {
-    videos.add({ video: req.files.input_video[0], data: req.body }, function (err) {
-      if (err) return next(err)
+  // ---------------------------------------------------------------------------
+
+  module.exports = router
+
+  // ---------------------------------------------------------------------------
+
+  function addVideo (req, res, next) {
+    var video_file = req.files.input_video[0]
+    var video_infos = req.body
+
+    videos.seed(video_file.path, function (err, torrent) {
+      if (err) {
+        logger.error('Cannot seed this video.')
+        return next(err)
+      }
+
+      var video_data = {
+        name: video_infos.name,
+        namePath: video_file.filename,
+        description: video_infos.description,
+        magnetUri: torrent.magnetURI
+      }
+
+      Videos.add(video_data, function (err) {
+        if (err) {
+          // TODO unseed the video
+          logger.error('Cannot insert this video in the database.')
+          return next(err)
+        }
+
+        // Now we'll add the video's meta data to our friends
+        friends.addVideoToFriends(video_data)
 
-      // TODO : include Location of the new video
-      res.sendStatus(201)
+        // TODO : include Location of the new video
+        res.sendStatus(201)
+      })
     })
   }
 
   function getVideos (req, res, next) {
-    videos.get(req.params.id, function (err, video) {
+    Videos.get(req.params.id, function (err, video) {
       if (err) return next(err)
 
       if (video === null) {
@@ -51,38 +95,52 @@
     })
   }
 
-  function removeVideo (req, res, next) {
-    videos.remove(req.params.id, function (err) {
+  function listVideos (req, res, next) {
+    Videos.list(function (err, videos_list) {
       if (err) return next(err)
 
-      res.sendStatus(204)
+      res.json(videos_list)
     })
   }
 
-  // multer configuration
-  var storage = multer.diskStorage({
-    destination: function (req, file, cb) {
-      cb(null, uploads)
-    },
+  function removeVideo (req, res, next) {
+    var video_id = req.params.id
+    Videos.get(video_id, function (err, video) {
+      if (err) return next(err)
 
-    filename: function (req, file, cb) {
-      var extension = ''
-      if (file.mimetype === 'video/webm') extension = 'webm'
-      else if (file.mimetype === 'video/mp4') extension = 'mp4'
-      else if (file.mimetype === 'video/ogg') extension = 'ogv'
-      crypto.pseudoRandomBytes(16, function (err, raw) {
-        var fieldname = err ? undefined : raw.toString('hex')
-        cb(null, fieldname + '.' + extension)
+      removeTorrent(video.magnetUri, function () {
+        Videos.removeOwned(req.params.id, function (err) {
+          if (err) return next(err)
+
+          var params = {
+            name: video.name,
+            magnetUri: video.magnetUri
+          }
+
+          friends.removeVideoToFriends(params)
+          res.sendStatus(204)
+        })
       })
-    }
-  })
-  var reqFiles = multer({ storage: storage }).fields([{ name: 'input_video', maxCount: 1 }])
+    })
+  }
 
-  router.get('/', miscMiddleware.cache(false), listVideos)
-  router.post('/', reqFiles, reqValidator.videosAdd, miscMiddleware.cache(false), addVideos)
-  router.get('/search/:name', reqValidator.videosSearch, miscMiddleware.cache(false), searchVideos)
-  router.get('/:id', reqValidator.videosGet, miscMiddleware.cache(false), getVideos)
-  router.delete('/:id', reqValidator.videosRemove, miscMiddleware.cache(false), removeVideo)
+  function searchVideos (req, res, next) {
+    Videos.search(req.params.name, function (err, videos_list) {
+      if (err) return next(err)
 
-  module.exports = router
+      res.json(videos_list)
+    })
+  }
+
+  // ---------------------------------------------------------------------------
+
+  // Maybe the torrent is not seeded, but we catch the error to don't stop the removing process
+  function removeTorrent (magnetUri, callback) {
+    try {
+      webtorrent.remove(magnetUri, callback)
+    } catch (err) {
+      logger.warn('Cannot remove the torrent from WebTorrent', { err: err })
+      return callback(null)
+    }
+  }
 })()