import { NextFunction, Request, Response } from 'express'
-import { ActivityPubSignature } from '../../shared'
+import { isActorDeleteActivityValid } from '@server/helpers/custom-validators/activitypub/actor'
+import { getAPId } from '@server/lib/activitypub/activity'
+import { ActivityDelete, ActivityPubSignature, HttpStatusCode } from '@shared/models'
import { logger } from '../helpers/logger'
import { isHTTPSignatureVerified, isJsonLDSignatureVerified, parseHTTPSignature } from '../helpers/peertube-crypto'
import { ACCEPT_HEADERS, ACTIVITY_PUB, HTTP_SIGNATURE } from '../initializers/constants'
-import { getOrCreateActorAndServerAndModel } from '../lib/activitypub'
-import { loadActorUrlOrGetFromWebfinger } from '../helpers/webfinger'
+import { getOrCreateAPActor, loadActorUrlOrGetFromWebfinger } from '../lib/activitypub/actors'
async function checkSignature (req: Request, res: Response, next: NextFunction) {
try {
// Forwarded activity
const bodyActor = req.body.actor
- const bodyActorId = bodyActor && bodyActor.id ? bodyActor.id : bodyActor
+ const bodyActorId = getAPId(bodyActor)
if (bodyActorId && bodyActorId !== actor.url) {
const jsonLDSignatureChecked = await checkJsonLDSignature(req, res)
if (jsonLDSignatureChecked !== true) return
return next()
} catch (err) {
- logger.error('Error in ActivityPub signature checker.', err)
- return res.sendStatus(403)
+ const activity: ActivityDelete = req.body
+ if (isActorDeleteActivityValid(activity) && activity.object === activity.actor) {
+ logger.debug('Handling signature error on actor delete activity', { err })
+ return res.status(HttpStatusCode.NO_CONTENT_204).end()
+ }
+
+ logger.warn('Error in ActivityPub signature checker.', { err })
+ return res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'ActivityPub signature could not be checked'
+ })
}
}
function executeIfActivityPub (req: Request, res: Response, next: NextFunction) {
const accepted = req.accepts(ACCEPT_HEADERS)
- if (accepted === false || ACTIVITY_PUB.POTENTIAL_ACCEPT_HEADERS.indexOf(accepted) === -1) {
+ if (accepted === false || ACTIVITY_PUB.POTENTIAL_ACCEPT_HEADERS.includes(accepted) === false) {
// Bypass this route
return next('route')
}
// ---------------------------------------------------------------------------
async function checkHttpSignature (req: Request, res: Response) {
- // FIXME: mastodon does not include the Signature scheme
+ // FIXME: compatibility with http-signature < v1.3
const sig = req.headers[HTTP_SIGNATURE.HEADER_NAME] as string
- if (sig && sig.startsWith('Signature ') === false) req.headers[HTTP_SIGNATURE.HEADER_NAME] = 'Signature ' + sig
+ if (sig && sig.startsWith('Signature ') === true) req.headers[HTTP_SIGNATURE.HEADER_NAME] = sig.replace(/^Signature /, '')
+
+ let parsed: any
+
+ try {
+ parsed = parseHTTPSignature(req, HTTP_SIGNATURE.CLOCK_SKEW_SECONDS)
+ } catch (err) {
+ logger.warn('Invalid signature because of exception in signature parser', { reqBody: req.body, err })
- const parsed = parseHTTPSignature(req)
+ res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: err.message
+ })
+ return false
+ }
const keyId = parsed.keyId
if (!keyId) {
- res.sendStatus(403)
+ res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'Invalid key ID',
+ data: {
+ keyId
+ }
+ })
return false
}
actorUrl = await loadActorUrlOrGetFromWebfinger(actorUrl.replace(/^acct:/, ''))
}
- const actor = await getOrCreateActorAndServerAndModel(actorUrl)
+ const actor = await getOrCreateAPActor(actorUrl)
const verified = isHTTPSignatureVerified(parsed, actor)
if (verified !== true) {
logger.warn('Signature from %s is invalid', actorUrl, { parsed })
- res.sendStatus(403)
+ res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'Invalid signature',
+ data: {
+ actorUrl
+ }
+ })
return false
}
res.locals.signature = { actor }
-
return true
}
const signatureObject: ActivityPubSignature = req.body.signature
if (!signatureObject || !signatureObject.creator) {
- res.sendStatus(403)
+ res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'Object and creator signature do not match'
+ })
return false
}
logger.debug('Checking JsonLD signature of actor %s...', creator)
- const actor = await getOrCreateActorAndServerAndModel(creator)
+ const actor = await getOrCreateAPActor(creator)
const verified = await isJsonLDSignatureVerified(actor, req.body)
if (verified !== true) {
logger.warn('Signature not verified.', req.body)
- res.sendStatus(403)
+ res.fail({
+ status: HttpStatusCode.FORBIDDEN_403,
+ message: 'Signature could not be verified'
+ })
return false
}
res.locals.signature = { actor }
-
return true
}